Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 346da7b in 40 seconds. Click for details.
- Reviewed
46lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/trufflehog.yml:17
- Draft comment:
Good fork‐safe checkout: using the repository field with persist-credentials: false is a solid security practice. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. .github/workflows/trufflehog.yml:23
- Draft comment:
Setting fetch-depth: 0 ensures full history for diff analysis; just verify that performance remains acceptable on very large repositories. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. .github/workflows/trufflehog.yml:28
- Draft comment:
Explicitly fetching the base commit (refs/heads/__base) is effective; ensure the base commit is always available in the remote. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
4. .github/workflows/trufflehog.yml:36
- Draft comment:
Verify that the extra_args '--fail --redact --results=verified,unknown' are fully supported by trufflehog v3.90.5; future updates might require adjustments. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_d6J6FkVwnjtcf3mv
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update
trufflehog.ymlto enhance PR scanning by making checkout fork-safe, fetching base commit, and usingextra_argsfor TruffleHog.trufflehog.ymlto make the checkout process fork-safe by usingactions/checkout@v4withpersist-credentials: falseandfetch-depth: 0.git fetch.extra_argsfor flags--fail,--redact, and--results=verified,unknown.This description was created by
for 346da7b. You can customize this summary. It will automatically update as commits are pushed.